Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support a scale parameter for the font size for stone markings. #177

Merged
merged 7 commits into from
Sep 17, 2024

Conversation

GreenAsJade
Copy link
Contributor

No description provided.

@anoek
Copy link
Member

anoek commented Sep 16, 2024

Hmm something with this messed up the top/sub positioning:

image

Should look more like this:

image

@GreenAsJade
Copy link
Contributor Author

Screenshot 2024-09-17 at 11 00 03 AM (2)

Note: I found another parameter sub_triangle, which doesn't seem to be tested in this board. It's such a teeny tweak in the maths, I'm kinda hoping it just does the right thing if/when needed 😝

If we know the "right context" for this to be tested in (how to actually set it in main.tsx testcase), I'm happy to add it: it's a parameter of the MoveTree interface, and it's also a valid `MARK_TYPE".

@GreenAsJade
Copy link
Contributor Author

Oh wait, I just saw that for some reason the original "sub" is actually centered in the square. Is that intended?

I imagined a sub would be positioned in a subscript position, so I didn't notice that I'd "broken" that!

@GreenAsJade
Copy link
Contributor Author

Latest (note that my Mac gives me bold font on stone lettering!)

Screenshot 2024-09-17 at 11 39 08 AM (2)

@anoek
Copy link
Member

anoek commented Sep 17, 2024

Awesome, thanks!

@anoek anoek merged commit 072d6ce into online-go:main Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants