Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
feature + code quality improvements
API changed or not: no
Description
Reduce the performance impact of dictionaries creation and lists building (plus remove import duplication and improve formatting).
How has this PR been tested?
list comprehension vs
list()
:10000000 loops, best of 5: 401 nsec per loop
10000000 loops, best of 5: 326 nsec per loop
dict()
vs{}
:10000000 loops, best of 5: 139 nsec per loop
10000000 loops, best of 5: 65.4 nsec per loop
Setup:
Dependency Change?
any library dependency introduced or removed: no