Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
diam/network_sctp.go
andexamples/s6a_client/main.go
files, focusing on improving SCTP connection handling and enhancing the S6a client example. The most important changes include adding SCTP_NODELAY options, refactoring the S6a client to use a base IMSI and delay between requests, and improving error handling and logging.SCTP Connection Handling:
Setsockopt
calls to enableSCTP_NODELAY
to theDial
methods indiam/network_sctp.go
to improve performance by disabling Nagle's algorithm. [1] [2]S6a Client Enhancements:
examples/s6a_client/main.go
to use a base IMSI (imsiBase
) and added a delay between requests (requestDelay
). This allows for better control over the client behavior and improved testing capabilities. [1] [2]sendAIR
andsendULR
functions to accept an IMSI parameter, allowing dynamic IMSI generation for each request. This helps in simulating multiple unique client requests. [1] [2]verbose
flag was added to control the verbosity of the logs. [1] [2]These changes aim to improve the performance, flexibility, and debuggability of the SCTP connections and the S6a client example.