Run the weekly coverage check in a container of its own - #304
Merged
Conversation
It was exec'd into the web container, so every deploy recreated that container and killed the run with it: five times in one week, and the deno process outlived the systemd unit as an orphan each time. compose run gives the check the same image, environment, volume and network, and a life of its own. Re-run the installer after merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weekly coverage check was
docker exec'd into the web container, so every deploy recreated that container and killed the run with it: five times between Monday and today, each time leaving an orphaned deno process behind. The unit now usesdocker compose run --rm --no-deps -T, which gives the check the same image, environment, volume and network, and a life of its own. Re-runscripts/install-production-coverage.shafter merging; a deploy does not touch the unit. Best merged after the run that is currently in progress finishes, since this merge's own deploy would kill it once more.