new UI

[mariusz-jachimowicz-83]

implement #78
implement #80

[lbradstreet]

This PR isn't working for me at the moment, as select-deployment doesn't exist (only select-deployment2 exists).

ANALYSIS ERROR: Invalid :refer, var var onyx-dashboard.components.deployment/select-deployment does not exist in file src/cljs/onyx_dashboard/components/main.cljs on file null, line null, column null
Successfully compiled "resources/public/js/app.js" in 37.835 seconds.

Once you fix that, I'll continue the review. Cheers!

[mariusz-jachimowicz-83]

Fixed

[mariusz-jachimowicz-83]

I hope you will be satisfied with this redesign.

[lbradstreet]

Thanks! I'll give it another go tomorrow :).

…

On 24 January 2017 at 00:55, Mariusz Jachimowicz ***@***.***> wrote: I hope you will be satisfied with this redesign. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#79 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPZHYCecr3W5OLURMZiAy2NWpNdtdxNks5rVbybgaJpZM4LeeIV> .

[lbradstreet]

I've tried to get this going in the repl via the instructions in the readme (i.e. repl reset, figwheel), but it's still loading the old interface.

Could you please give me some instructions to try it out in the repl?

Thanks!

[mariusz-jachimowicz-83]

Strange. I will check it.

[lbradstreet]

Quite strange. I did see it briefly load with the new UI. I cleaned all of the out dir and ran lein clean, but it's still loading the old interface. Thanks!

…

On 26 Jan 2017, at 00:35, Mariusz Jachimowicz ***@***.***> wrote: Strange. I will check it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[mariusz-jachimowicz-83]

I did

git clone [email protected]:mariusz-jachimowicz-83/onyx-dashboard.git onyx-new-ui
cd onyx-new-ui
git fetch origin new_layout
git checkout -t origin/new_layout

lein run -m onyx.peer.dag-test

;;open second terminal window
lein repl
(onyx-dashboard.dev/start-figwheel)
(user/stop) (clojure.tools.namespace.repl/refresh) (user/go "127.0.0.1:2188")

It's working. I see new UI.

[lbradstreet]

Thanks. That's what I did, but I didn't do a fresh clone. I'll give it another go from a fresh clone tomorrow

…

On 26 Jan 2017, at 00:51, Mariusz Jachimowicz ***@***.***> wrote: I did git clone ***@***.***:mariusz-jachimowicz-83/onyx-dashboard.git onyx-new-ui cd onyx-new-ui git fetch origin new_layout git checkout -t origin/new_layout lein run -m onyx.peer.dag-test ;;open second terminal window lein repl (onyx-dashboard.dev/start-figwheel) (user/stop) (clojure.tools.namespace.repl/refresh) (user/go "127.0.0.1:2188") I is working. I see new UI. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[lbradstreet]

Thanks. I got it working via your instructions.

It definitely looks nice, but there are some elements that I find confusing due to the way that views are switched between, since each selection is making the view more specific, but this isn't being conveyed by the left bar. I don't think the changes required will be too major but I need to think about it a bit.

I think if the left bar was more of a tree view then it would be less confusing.

e.g.

Tenancy
----- tenancy XXX
------- job X (selected)
----------- job x view
----------- job x log

Find me on clojurians and we'll chat about it some more.

Thanks!

[mariusz-jachimowicz-83]

One issue with this is that tenancy and jobs have very long ids.

My intention was to do simplest layout close to most common layouts for analytics apps. So common pattern is to have sections and display it on top or left side.
My current solution is similar to Apache Flink dashboard I think. It should be ok for now. We can change/improve it in the future when we add more functions.

[mariusz-jachimowicz-83]

But of course I don't mind if you want different layout style.

[lbradstreet]

That's a very good point that the job-ids and tenancy-ids are quite long. I'll give it some more thought.