Skip to content

Conversation

@sdsantos
Copy link
Contributor

@sdsantos sdsantos commented Oct 14, 2025

@sdsantos sdsantos changed the title Move tests to separate screen Dashboard Redesign Oct 14, 2025
@sdsantos sdsantos force-pushed the dashboard-redesign branch 2 times, most recently from 6700141 to a671c45 Compare October 22, 2025 11:15
@sdsantos sdsantos marked this pull request as ready for review October 22, 2025 14:55
@sdsantos sdsantos requested a review from aanorbel October 22, 2025 14:56
Copy link
Member

@aanorbel aanorbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. We just need to make some adjustments for the stuff like json

}

private fun SelectAllWithNetwork.toModel(): ResultWithNetworkAndAggregates? {
private fun org.ooni.probe.data.ResultWithNetworkAndAggregates.toModel(): ResultWithNetworkAndAggregates? {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import Class

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this one, because that's the class generated by Sqldelight, and we have another one with the same name. Or we find a better name for our ResultWithNetworkAndAggregates.

Copy link
Member

@aanorbel aanorbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard Redesign

3 participants