-
Notifications
You must be signed in to change notification settings - Fork 34
Rework field assignability analysis #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
maximilianruesch
wants to merge
43
commits into
develop
Choose a base branch
from
rework/field-assignability
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,967
−1,675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # DEVELOPING_OPAL/validate/src/test/java/org/opalj/fpcf/fixtures/immutability/openworld/lazyinitialization/primitive_types/LazyInitializationPrimitiveTypes.java # DEVELOPING_OPAL/validate/src/test/java/org/opalj/fpcf/fixtures/immutability/openworld/stringelements/SimpleStringModel.java # OPAL/tac/src/main/scala/org/opalj/tac/fpcf/analyses/fieldassignability/AbstractFieldAssignabilityAnalysis.scala # OPAL/tac/src/main/scala/org/opalj/tac/fpcf/analyses/fieldassignability/L2FieldAssignabilityAnalysis.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field assignability analysis has gone through many amends since its initial introduction, reducing code clarity, maintainability, and extensibility to what could be considered a negative. A recent example of this is the review in #190 (review). It became clear that many of the amends done were symptomatic fixes done to satisfy some edge case, but not fix the underlying issue.
This PR aims to do several things (in no particular order):
Besides the titular complete overhaul of the analysis, the PR achieves this by:
i. Parts are traits that register themselves with in the abstract analysis when they are included in the analysis inheritance hierarchy
ii. The order of parts is fixed through Scala's linearisation of traits
This PR acknowledges the additional test cases ("advanced counter examples") developed in #190 and integrates them.
This PR does not (yet):
Support pickup / drop
The overhaul changes results in integration tests, which are explained here (currently an incomplete list):
Now supported
Now Unsupported
thisinstance: Examples include inline lazy initializers for.classvalues generated by compilers before JDK 5 (the relevant integration test filebatik-util 1.7.jarwas produced with JDK 1.1). SeeGeneratedClassConstantLazyInittest for further information.