Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dataprep CI and fix pptx file ingesting bug #1334

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lianhao
Copy link
Collaborator

@lianhao lianhao commented Feb 26, 2025

Description

  • Fix permission issue for when ingesting pptx file with embedded image
  • Add more test coverage to the dataprep CI
  • Unify common dataprep CI test code

Issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

n/a.

Tests

CI.

@lianhao
Copy link
Collaborator Author

lianhao commented Feb 26, 2025

The CI is blocked by a non-relevant issue #1332

@lianhao lianhao force-pushed the bug1324 branch 2 times, most recently from 19965f6 to 8daeb34 Compare February 27, 2025 04:03
Fix 'permission denied' error when ingesting pptx files with embedded
images.

Signed-off-by: Lianhao Lu <[email protected]>
1. Added more tests for uploading more types of files

2. Unified the common test code

Signed-off-by: Lianhao Lu <[email protected]>
@chensuyue
Copy link
Collaborator

chensuyue commented Feb 27, 2025

Separate the bug fix for #1332. This is a common issue and break all the CI test. So let's merge first in another PR. #1340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants