Skip to content

fix: missing (1+qv) factor in calculation of derivative of rho_d when… #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: missing (1+qv) factor in calculation of derivative of rho_d when… #614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/PyMPDATA_examples/Shipway_and_Hill_2012/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def drhod_dz(z, rhod):
if not apprx_drhod_dz: # to resolve issue #335
qv = self.qv(z)
dqv_dz = Derivative(self.qv)(z)
drhod_dz = drhod_dz / (1 + qv) - rhod * dqv_dz / (1 + qv)
drhod_dz = drhod_dz / (1 + qv) - rhod * dqv_dz / (1 + qv)**2
return drhod_dz

z_points = np.arange(0, self.z_max + self.dz / 2, self.dz / 2)
Expand Down
Loading