Skip to content

add smoke test checking error measures for the Shima_et_al_2009 box example. Closes #327#1191

Merged
slayoo merged 14 commits intoopen-atmos:mainfrom
slayoo:new_shima_2009_smoke_test
Jun 5, 2025
Merged

add smoke test checking error measures for the Shima_et_al_2009 box example. Closes #327#1191
slayoo merged 14 commits intoopen-atmos:mainfrom
slayoo:new_shima_2009_smoke_test

Conversation

@slayoo
Copy link
Member

@slayoo slayoo commented Dec 1, 2023

No description provided.

@slayoo slayoo requested a review from piotrbartman December 1, 2023 00:06
@slayoo
Copy link
Member Author

slayoo commented Dec 1, 2023

TODO: check exception type via mark.xfail

@slayoo slayoo closed this Dec 5, 2023
@slayoo slayoo reopened this Dec 5, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2024

Stale pull request message

@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.53%. Comparing base (a955f80) to head (7ef56b3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1191   +/-   ##
=======================================
  Coverage   85.53%   85.53%           
=======================================
  Files         396      396           
  Lines        9601     9601           
=======================================
  Hits         8212     8212           
  Misses       1389     1389           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@slayoo
Copy link
Member Author

slayoo commented Jun 5, 2025

I can't review/approve here as I'm the PR creator, but I think that's ready and very much worth merging. Thanks @AgnieszkaZaba and @piotrbartman !

@AgnieszkaZaba AgnieszkaZaba self-requested a review June 5, 2025 08:09
@AgnieszkaZaba
Copy link
Collaborator

Workaround is applied for matplotlib bug mentioned in matplotlib/matplotlib#9970.
We can't bump matplotlib version to 3.10.3 due to incompatibility with Python 3.9.

@slayoo PR ready to merge.

@slayoo slayoo merged commit e7f9982 into open-atmos:main Jun 5, 2025
197 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants