Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vapour deposition on ice; introducing physics.latent_heat_sublimation (and renamings in physics: latent_heat to latent_heat_vapourisation, condensation_coordinate to diffusion_coordinate) #1389

Open
wants to merge 55 commits into
base: main
Choose a base branch
from

Conversation

slayoo
Copy link
Member

@slayoo slayoo commented Sep 17, 2024

No description provided.

@slayoo
Copy link
Member Author

slayoo commented Sep 27, 2024

thank you @tluettm !

@tluettm
Copy link
Collaborator

tluettm commented Feb 17, 2025

@slayoo Can you check the latest merges? Since it is your pull request I can not request you as a reviewer here. I will need vapor deposition on ice to test homogeneous freezing implementation.

@slayoo slayoo changed the title new dynamic: vapour deposition on ice vapour deposition on ice Mar 22, 2025
@slayoo slayoo changed the title vapour deposition on ice vapour deposition on ice; physics.latent_heat_sublimation (and renaming latent_heat to latent_heat_vapourisation) Mar 23, 2025
@slayoo slayoo changed the title vapour deposition on ice; physics.latent_heat_sublimation (and renaming latent_heat to latent_heat_vapourisation) vapour deposition on ice; physics.latent_heat_sublimation (and renaming physics.latent_heat to physics.latent_heat_vapourisation) Mar 23, 2025
Copy link

codecov bot commented Mar 23, 2025

Codecov Report

Attention: Patch coverage is 90.84967% with 14 lines in your changes missing coverage. Please review.

Project coverage is 85.41%. Comparing base (9cc2e06) to head (a99651d).

Files with missing lines Patch % Lines
PySDM/physics/diffusion_ice_kinetics/neglect.py 66.66% 5 Missing ⚠️
PySDM/physics/diffusion_ice_kinetics/standard.py 75.00% 4 Missing ⚠️
.../backends/impl_numba/methods/deposition_methods.py 98.00% 1 Missing ⚠️
PySDM/physics/diffusion_ice_capacity/spherical.py 83.33% 1 Missing ⚠️
...hysics/latent_heat_sublimation/murphy_koop_2005.py 85.71% 1 Missing ⚠️
.../particle_shape_and_density/mixed_phase_spheres.py 66.66% 1 Missing ⚠️
PySDM/physics/trivia.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1389      +/-   ##
==========================================
+ Coverage   85.33%   85.41%   +0.07%     
==========================================
  Files         380      389       +9     
  Lines        9378     9516     +138     
==========================================
+ Hits         8003     8128     +125     
- Misses       1375     1388      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@slayoo slayoo changed the title vapour deposition on ice; physics.latent_heat_sublimation (and renaming physics.latent_heat to physics.latent_heat_vapourisation) vapour deposition on ice; introducing physics.latent_heat_sublimation (and renamings in physics: latent_heat to latent_heat_vapourisation, condensation_coordinate to diffusion_coordinate) Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants