Skip to content

Dev #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

Dev #32

wants to merge 26 commits into from

Conversation

glind
Copy link
Contributor

@glind glind commented Mar 27, 2025

Merge upstream changes with version fixes

@glind glind requested a review from Copilot March 27, 2025 14:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR merges upstream changes while applying version fixes and improvements. Key changes include:

  • Minor corrections and clarifications in docstrings and comments.
  • Enhanced dependency initialization and function handling in main.py.
  • Updates to deployment configurations and AI model response processing in ai_configurator.py.
  • Adjustments in CI workflows and docker-compose settings for improved deployment.

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
message_logger.py Fixed typos in docstrings and clarified logging description.
main.py Improved dependency initialization and enhanced function calls.
docker-compose.yml Updated environment and CORS settings for deployment.
ai_configurator.py Enhanced conversation state management and AI model configuration.
.github/workflows/dev-build.yml Updated build image and added a new deployment step to Kapstan.
Files not reviewed (2)
  • Dockerfile: Language not supported
  • example.env: Language not supported
Comments suppressed due to low confidence (2)

message_logger.py:4

  • Typo in 'retrievening'; consider revising it to 'retrieving'.
 Log messages sent through the chatbot and allow for retrievening them later.

message_logger.py:5

  • Typo in 'SQLListe'; consider revising it to 'SQLite' if that was the intended database.
 This is implemented in SQLListe for testing purposes.  Would be better to implement in 

Copy link
Contributor Author

@glind glind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid comment

@glind glind marked this pull request as ready for review March 27, 2025 14:15
@glind glind requested a review from Copilot March 27, 2025 14:16
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR merges upstream changes and version fixes to improve API error handling, token management, configuration loading, and deployment steps. Key changes include updating asynchronous model response handling in main.py and ai_configurator.py, refining environment variable configuration in docker-compose.yml, and adding a new deployment step in the workflow.

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
message_logger.py Minor whitespace adjustments and a docstring containing a typo
main.py Updated async call for processing responses and improved CORS setup
docker-compose.yml Modified environment variable definitions for CORS_ALLOWED_DOMAINS
ai_configurator.py Refactored conversation history management and token deduction logic
.github/workflows/dev-build.yml Added Kapstan deployment step and updated the IMAGE_NAME configuration
Files not reviewed (2)
  • Dockerfile: Language not supported
  • example.env: Language not supported
Comments suppressed due to low confidence (1)

message_logger.py:4

  • Fix the typo 'retrievening' to 'retrieving'.
Log messages sent through the chatbot and allow for retrievening them later.

@glind glind requested a review from Copilot March 27, 2025 14:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Merge upstream changes with version fixes to improve logging, error handling, and configuration.

  • Updated documentation and minor formatting in message_logger.py.
  • Refactored main.py for asynchronous processing, improved logging, and safe prompt sampling.
  • Enhanced conversation state management in ai_configurator.py and updated environment variable settings in docker-compose.yml and workflow deployment steps.

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
message_logger.py Updated docstring and formatting; contains some spelling errors.
main.py Refactored async processing, logging, and prompt sampling logic.
docker-compose.yml Updated environment variable syntax for CORS_ALLOWED_DOMAINS.
ai_configurator.py Enhanced conversation history management and token handling.
.github/workflows/dev-build.yml Changed image repository name and added a deployment step.
Files not reviewed (2)
  • Dockerfile: Language not supported
  • example.env: Language not supported
Comments suppressed due to low confidence (2)

message_logger.py:4

  • There is a spelling mistake in 'retrievening'; it should be 'retrieving'.
Log messages sent through the chatbot and allow for retrievening them later.

message_logger.py:5

  • The term 'SQLListe' appears to be misspelled; if the intention is to refer to SQLite, please correct it.
This is implemented in SQLListe for testing purposes.  Would be better to implement in 

@glind glind requested a review from Copilot March 27, 2025 14:44
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request merges upstream changes to update documentation, fix spelling errors, and improve version fixes across several files. Key changes include documentation and typo corrections in message_logger.py, restructuring and enhanced error logging in main.py, updated environment variable definitions in docker-compose.yml, and refactored conversation history and token management in ai_configurator.py.

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
message_logger.py Updated module docstring with spelling corrections
main.py Improved dependency import order, error logging, and prompt handling
docker-compose.yml Added and reformatted environment variable for CORS domains
ai_configurator.py Refactored conversation history management and error handling
.github/workflows/dev-build.yml Updated IMAGE_NAME and added a deployment step to Kapstan
Files not reviewed (2)
  • Dockerfile: Language not supported
  • example.env: Language not supported
Comments suppressed due to low confidence (2)

message_logger.py:4

  • The word 'retrievening' appears to be misspelled. Consider changing it to 'retrieving'.
Log messages sent through the chatbot and allow for retrievening them later.

message_logger.py:5

  • The term 'SQLListe' may be a typo. If you meant 'SQLite', please correct the spelling.
This is implemented in SQLListe for testing purposes.  Would be better to implement in 

@glind glind requested a review from Copilot April 15, 2025 15:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • Dockerfile: Language not supported
  • example.env: Language not supported
Comments suppressed due to low confidence (2)

message_logger.py:4

  • Typo in docstring: 'retrievening' should be corrected to 'retrieving'.
 Log messages sent through the chatbot and allow for retrievening them later.

docker-compose.yml:16

  • Verify that the value for CORS_ALLOWED_DOMAINS is correctly formatted; the colon within the value may lead to parsing issues.
 - CORS_ALLOWED_DOMAINS:'["http://localhost","https://localhost","http://localhost:3000","https://localhost:3000"]'

try:
ai_configurator.set_model(provider, llm, tokenizer_function, completion_function, use_initial_prompt=True)
chat_response = ai_configurator.get_response(history, user_message, tokens)
chat_response = await ai_configurator.process_response(history, user_message, tokens) # Fixed call
Copy link
Preview

Copilot AI Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'process_response' function is not declared as asynchronous; either remove the 'await' operator or update the function to be async.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants