fix: compliant with mustnothave and objectselector #408
Conversation
dhaiducek
force-pushed
the
25562-mustnothave-objsel
branch
2 times, most recently
from
75eb217 to
5f92b6b
Compare
| for ns := range relevantNsNames { | ||
| namespaces = append(namespaces, ns) | ||
| } |
There was a problem hiding this comment.
This is basically pulling all the namespaces from namespace/namespaceSelector. I realized I'm missing populating relatedObjects. I'll check to see what mustnothave with unnamed objects does and see whether it makes sense to do that here also.
JustinKuli
left a comment
JustinKuli
left a comment
There was a problem hiding this comment.
What's here looks good! Just holding in case we want to update any related object information like you commented.
/hold
dhaiducek
force-pushed
the
25562-mustnothave-objsel
branch
from
5f92b6b to
032e9fc
Compare
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dhaiducek
force-pushed
the
25562-mustnothave-objsel
branch
2 times, most recently
from
a839659 to
1e86265
Compare
When a mustnothave ConfigurationPolicy returns objects from the objectSelector but no objects match the policy, the status wasn't populated. This populates a compliant status for this case. ref: https://issues.redhat.com/browse/ACM-25562 Signed-off-by: Dale Haiducek <[email protected]>
dhaiducek
force-pushed
the
25562-mustnothave-objsel
branch
from
1e86265 to
fa6c249
Compare
2 participants
When a mustnothave ConfigurationPolicy returns objects from the objectSelector but no objects match the policy, the status wasn't populated. This populates a compliant status for this case.
ref: https://issues.redhat.com/browse/ACM-25562
Followup to:
Assisted-by: Cursor IDE using claude-4.5-sonnet