-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP 🐛 Fix: make kube a default value of workloadsourcedriver. #375
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xuezhaojun The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
=======================================
Coverage 61.37% 61.37%
=======================================
Files 132 132
Lines 14051 14051
=======================================
Hits 8624 8624
Misses 4672 4672
Partials 755 755
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fad06ac
to
7791d11
Compare
@@ -28,6 +30,7 @@ func NewWorkloadAgentOptions() *WorkloadAgentOptions { | |||
MaxJSONRawLength: 1024, | |||
StatusSyncInterval: 10 * time.Second, | |||
AppliedManifestWorkEvictionGracePeriod: 60 * time.Minute, | |||
WorkloadSourceDriver: work.ConfigTypeKube, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need to default the kubcoonfig file path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, added.
Signed-off-by: GitHub <[email protected]>
7791d11
to
99b1f1a
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixed by another PR, close |
@xuezhaojun: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Summary
We want use kube as the default driver even no driver set.