-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix manifestwork and appliedmanifestwork unsync issue #636
🐛 Fix manifestwork and appliedmanifestwork unsync issue #636
Conversation
/hold |
eb1bf59
to
133ebcf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
==========================================
+ Coverage 63.64% 63.75% +0.10%
==========================================
Files 182 183 +1
Lines 17634 17615 -19
==========================================
+ Hits 11223 11230 +7
+ Misses 5480 5458 -22
+ Partials 931 927 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
133ebcf
to
e2763fb
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
11c472e
to
333faf4
Compare
} | ||
|
||
return err | ||
if !mwUpdated && !amwUpdated && requeueTime < MaxRequeueDuration { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a case where a ManifestWork includes more than 1 manifest and one of them is failed to apply due to lack of permission, wmUpdated
and amwUpdated
will be true
and requeueTime
will be less than MaxRequeueDuration
, but the requeue is still needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so
merge the two controller as reconcilers for one controller Signed-off-by: Jian Qiu <[email protected]>
Signed-off-by: Jian Qiu <[email protected]>
333faf4
to
64d8f73
Compare
/lgtm |
/unhold |
5911a7e
into
open-cluster-management-io:main
merge the two controller as reconcilers for one controller
Summary
Related issue(s)
Fixes #