Skip to content

📖 Add a security self assessment doc #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Mar 9, 2025

Summary

Related issue(s)

#793

Fixes #

@openshift-ci openshift-ci bot requested review from deads2k and jnpacker March 9, 2025 04:24
Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.38%. Comparing base (9024cb0) to head (721b999).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #876   +/-   ##
=======================================
  Coverage   64.38%   64.38%           
=======================================
  Files         193      193           
  Lines       18926    18926           
=======================================
  Hits        12185    12185           
  Misses       5743     5743           
  Partials      998      998           
Flag Coverage Δ
unit 64.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhujian7
Copy link
Member Author

/cc @qiujian16 @mikeshng

@openshift-ci openshift-ci bot requested review from mikeshng and qiujian16 March 11, 2025 08:06
@qiujian16
Copy link
Member

/approve

Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member

/assign @mikeshng

@mikeshng
Copy link
Member

CC @pshickeydev

Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits. There are also some TODO in the file. Is that ok?

@zhujian7 zhujian7 force-pushed the self-assessment branch 2 times, most recently from a0676f9 to effcf27 Compare April 1, 2025 14:48
@zhujian7
Copy link
Member Author

zhujian7 commented Apr 1, 2025

There are also some TODO in the file. Is that ok?

Now there is only one TODO: Add 2-3 Case Studies, @mikeshng @qiujian16 could you help provide some case studies?

references: https://tag-security.cncf.io/community/assessments/guide/self-assessment/

Case Studies. Provide context for reviewers by detailing 2-3 scenarios of real-world use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants