Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Separate crd objects from others #882

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhujian7
Copy link
Member

Summary

Separate crd objects from others, so clusteradm can apply the crd objects first, after making sure the crd objects are created, then creates other resources.

Related issue(s)

open-cluster-management-io/clusteradm#469 (comment)

Fixes #

@zhujian7
Copy link
Member Author

/cc @qiujian16 @zhiweiyin318

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 63.77%. Comparing base (8b3a820) to head (8143d4b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/operator/helpers/chart/render.go 52.63% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #882   +/-   ##
=======================================
  Coverage   63.76%   63.77%           
=======================================
  Files         193      193           
  Lines       18975    18977    +2     
=======================================
+ Hits        12100    12102    +2     
  Misses       5880     5880           
  Partials      995      995           
Flag Coverage Δ
unit 63.77% <57.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhujian7 zhujian7 force-pushed the crd-objects branch 2 times, most recently from a398d15 to 8143d4b Compare March 11, 2025 14:23
@qiujian16
Copy link
Member

/approve

@zhiweiyin318 needs to take a final review

Copy link
Contributor

openshift-ci bot commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants