Skip to content

Grpc impl #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

qiujian16
Copy link
Member

Summary

Related issue(s)

Fixes #

Copy link
Contributor

openshift-ci bot commented Apr 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 1, 2025
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 1.64440% with 957 lines in your changes missing coverage. Please review.

Project coverage is 61.23%. Comparing base (f4b6dcb) to head (525342e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/registration/register/grpc/spoke_driver.go 0.00% 244 Missing ⚠️
pkg/server/grpc/server.go 0.00% 199 Missing ⚠️
pkg/registration/register/grpc/hub_driver.go 0.00% 88 Missing ⚠️
pkg/server/services/cluster.go 0.00% 72 Missing ⚠️
pkg/server/services/lease.go 0.00% 63 Missing ⚠️
pkg/server/services/addon.go 0.00% 61 Missing ⚠️
pkg/server/services/csr.go 0.00% 60 Missing ⚠️
pkg/registration/register/grpc/options.go 3.84% 50 Missing ⚠️
pkg/server/services/event.go 0.00% 48 Missing ⚠️
pkg/server/grpc/authn/token.go 0.00% 26 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #929      +/-   ##
==========================================
- Coverage   64.29%   61.23%   -3.06%     
==========================================
  Files         194      206      +12     
  Lines       19015    19981     +966     
==========================================
+ Hits        12225    12236      +11     
- Misses       5782     6736     +954     
- Partials     1008     1009       +1     
Flag Coverage Δ
unit 61.23% <1.64%> (-3.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qiujian16 qiujian16 force-pushed the grpc-impl branch 4 times, most recently from 34445dc to 3ef89c6 Compare April 8, 2025 06:59
@qiujian16 qiujian16 force-pushed the grpc-impl branch 3 times, most recently from 6d53b20 to 003e8f1 Compare April 9, 2025 10:09
Signed-off-by: Jian Qiu <[email protected]>

Enable tls/authn

Signed-off-by: Jian Qiu <[email protected]>

Generat config file of grpc

Signed-off-by: Jian Qiu <[email protected]>

Update decode/encode to work

Signed-off-by: Jian Qiu <[email protected]>

Add lease/event service

Signed-off-by: Jian Qiu <[email protected]>

Add lease store impl

Signed-off-by: Jian Qiu <[email protected]>

add cluster label to kube informers

Signed-off-by: Wei Liu <[email protected]>

update sdk-go

Signed-off-by: Jian Qiu <[email protected]>
qiujian16 and others added 2 commits April 23, 2025 11:34
Signed-off-by: Jian Qiu <[email protected]>

Enable tls/authn

Signed-off-by: Jian Qiu <[email protected]>

Generat config file of grpc

Signed-off-by: Jian Qiu <[email protected]>

Update decode/encode to work

Signed-off-by: Jian Qiu <[email protected]>

Add lease/event service

Signed-off-by: Jian Qiu <[email protected]>

Add lease store impl

Signed-off-by: Jian Qiu <[email protected]>

add cluster label to kube informers

Signed-off-by: Wei Liu <[email protected]>

add the grpc config to template

Signed-off-by: Wei Liu <[email protected]>

add the grpc config to template

Signed-off-by: Wei Liu <[email protected]>

work service

Signed-off-by: Wei Liu <[email protected]>

work service

Signed-off-by: Wei Liu <[email protected]>

support event patch

Signed-off-by: Wei Liu <[email protected]>

Implement grpc

Signed-off-by: Jian Qiu <[email protected]>

Enable tls/authn

Signed-off-by: Jian Qiu <[email protected]>

Generat config file of grpc

Signed-off-by: Jian Qiu <[email protected]>

Update decode/encode to work

Signed-off-by: Jian Qiu <[email protected]>

Add lease/event service

Signed-off-by: Jian Qiu <[email protected]>

Add lease store impl

Signed-off-by: Jian Qiu <[email protected]>

add cluster label to kube informers

Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

skeeey and others added 2 commits April 29, 2025 15:46
Signed-off-by: Wei Liu <[email protected]>
add the grpc config to template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants