Fix str(res) typo in post_check for non-numeric answers - #1680
Merged
ssiq merged 1 commit intoSep 18, 2026
Merged
Conversation
Collaborator
|
Thanks for the updates. These three commits seem to address separate issues:
Would you mind splitting them into three separate PRs? That would make the changes easier to review, test, and merge independently. |
The non-numeric branch of post_check compared str(res) where res is always None, so free-form questions with a non integer/float answer type could never be scored correct, even when the GPT judge extracted the right answer. Day-one typo from open-compass#29; lens.py and ocr_reasoning.py, which were derived from the same template, correctly use str(response) here. qspatial.py copied the same typo. Fixes open-compass#1679
rrrxxx0510
force-pushed
the
fix/mathvista-post-check-str-res
branch
from
September 14, 2026 11:40
22f1f20 to
d6cc31b
Compare
Contributor
Author
|
Both PRs are now single-commit — the fallback fix stays in #1676 and the typo fix in #1680. The extra_records change was never supposed to be in there, it sits on its own branch and I'll send it as a separate PR once #1665 gets some feedback. My bad for stacking the branches, and thanks for catching it. |
Contributor
Author
|
按你说的拆好了,单 commit——typo 这条单独留着,fallback 那个归 #1676。 force-push 之后 CI 批准被重置了,两个 check 还都是 action_required 没跑起来。麻烦再看下 workflow? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1679
The non-numeric branch of
post_checkcomparedstr(res)whereresis alwaysNone, so free-form questions with a non integer/float answer type could never be scored correct, even when the GPT judge extracted the right answer.Day-one typo from #29.
lens.pyandocr_reasoning.py, which were derived from the same template, correctly usestr(response)here — confirming the intended behavior.qspatial.pycopied the same typo; fixed both.On the shipped
MathVista_MINITSV the blast radius is the 2 samples withanswer_type == 'list'(the 540 text answers are all multi-choice and take the other branch), so this mostly matters for correctness and for any future/custom TSVs with free-form text answers.Verified with a direct call into
post_checkbefore and after: a correct text answer was marked wrong before, and is scored correctly after; wrong answers and integer answers behave unchanged.