-
Notifications
You must be signed in to change notification settings - Fork 14
feat: scenarios for type mismatch across the value types #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aepfli
wants to merge
2
commits into
main
Choose a base branch
from
feat/type-mismatch-scenarios
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+79
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| @rpc @in-process @file @type-mismatch | ||
| Feature: flagd type mismatch handling | ||
|
|
||
| # Validates that asking for a flag through the wrong accessor returns the caller's default | ||
| # with error code TYPE_MISMATCH, rather than a coerced value. A coerced value is the worst | ||
| # failure mode a flag has: the application receives something plausible and no signal that | ||
| # anything went wrong. | ||
| # | ||
| # Numeric coercion is deliberately absent. Whether 0.5 may be narrowed to an integer is | ||
| # unsettled in the specification (https://github.com/open-feature/spec/issues/430), and | ||
| # flagd's own ADR permits coercion when it is lossless -- so an integer/float row here would | ||
| # assert a rule that does not exist yet. "Is a string a boolean?" has no such defence. | ||
| # | ||
| # It's associated with the flags configured in flags. | ||
|
|
||
| Scenario Outline: Requesting the wrong type returns the default | ||
| Given an option "cache" of type "CacheType" with value "disabled" | ||
| And a stable flagd provider | ||
| And a <type>-flag with key "<key>" and a default value "<default>" | ||
| When the flag was evaluated with details | ||
| Then the resolved details value should be "<default>" | ||
| And the reason should be "ERROR" | ||
| And the error-code should be "TYPE_MISMATCH" | ||
|
|
||
| Examples: a string flag requested as something else | ||
| | key | type | default | | ||
| | string-flag | Boolean | false | | ||
| | string-flag | Integer | 1 | | ||
| | string-flag | Float | 0.1 | | ||
| | wrong-flag | Boolean | false | | ||
|
|
||
| Examples: a boolean flag requested as something else | ||
| # The two numeric rows are the ones that catch a language where the boolean type is a | ||
| # subtype of the integer type, as it is in Python: isinstance(True, int) is True, so a | ||
| # naive check admits a boolean and the caller is handed 1 or 1.0 with no error. | ||
| | key | type | default | | ||
| | boolean-flag | String | fallback | | ||
| | boolean-flag | Integer | 1 | | ||
| | boolean-flag | Float | 0.1 | | ||
|
|
||
| Examples: a numeric flag requested as a non-numeric type | ||
| | key | type | default | | ||
| | integer-flag | Boolean | false | | ||
| | integer-flag | String | fallback | | ||
| | float-flag | Boolean | false | | ||
| | float-flag | String | fallback | |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.