-
Notifications
You must be signed in to change notification settings - Fork 66
updated all dependencies -- all packages #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
Summary of ChangesHello @kratos069, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the dependencies of various Go modules within the repository. The updates include both direct and indirect dependencies, as well as upgrading the Go version used by the modules. This ensures the project is using the latest versions of its dependencies, incorporating bug fixes, performance improvements, and new features. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates dependencies across numerous Go modules, including upgrading the Go version to 1.24.0. While this is a good maintenance task, it appears that for several modules, the go.mod file was updated but the corresponding go.sum file is not included in the changes. This will cause build failures for anyone pulling these changes without a populated module cache and breaks reproducible builds. It is critical to run go mod tidy within each modified module's directory and commit the updated go.sum files.
| module github.com/open-feature/go-sdk-contrib/hooks/open-telemetry | ||
|
|
||
| go 1.23.0 | ||
| go 1.24.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this module (hooks/open-telemetry) correctly includes updates for both go.mod and go.sum, it seems that several other modules in this PR are missing their corresponding go.sum updates (e.g., providers/harness, providers/launchdarkly, providers/go-feature-flag-in-process, etc.). This is a critical issue that will lead to non-reproducible builds and may cause CI/CD pipelines or other developers' builds to fail. Please run go mod tidy in all modified module directories and commit the resulting go.sum files.
This PR
Related Issues
Fixes #1234523
Notes
Follow-up Tasks
How to test