feat: Add multi-provider support #1500
Conversation
Signed-off-by: suvaidkhan <[email protected]>
suvaidkhan
force-pushed
the
suvaidkhan/add-multiprovider-support
branch
from
8710a52 to
f07dd25
Compare
|
| private String metadataName; | ||
|
|
||
| /** | ||
| * Constructs a MultiProvider with the given list of FeatureProviders, using a default strategy. |
There was a problem hiding this comment.
I think the comment should say what the default strategy is
| json.put("name", NAME); | ||
| JSONObject providersMetadata = new JSONObject(); | ||
| json.put("originalMetadata", providersMetadata); | ||
| ExecutorService initPool = Executors.newFixedThreadPool(INIT_THREADS_COUNT); |
There was a problem hiding this comment.
| ExecutorService initPool = Executors.newFixedThreadPool(INIT_THREADS_COUNT); | |
| ExecutorService initPool = Executors.newFixedThreadPool(Math.min(INIT_THREADS_COUNT, providers.size())); |
| throw new GeneralError("init failed"); | ||
| } | ||
| } | ||
| metadataName = json.toString(); |
There was a problem hiding this comment.
If the executer service is unused from this point onwards, we should shut it down
| assertThrows(FlagNotFoundError.class, () -> finalMultiProvider1.getStringEvaluation("non-existing", "", null)); | ||
|
|
||
| multiProvider.shutdown(); | ||
| multiProvider = new MultiProvider(providers, new FirstSuccessfulStrategy()); |
There was a problem hiding this comment.
There should probably be a test file with tests for each strategy. If you want to reduce code duplication by the flag setup, make those test classes extend some common test setup class
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1500 +/- ##
============================================
+ Coverage 92.97% 93.63% +0.65%
- Complexity 488 519 +31
============================================
Files 46 49 +3
Lines 1182 1257 +75
Branches 103 112 +9
============================================
+ Hits 1099 1177 +78
+ Misses 53 49 -4
- Partials 30 31 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Should I construct the json using Strings? |
|
Maybe it would be worth it. |
|
@chrfwow @toddbaert any updates on this? |
This PR
Related Issues
Resolves #1486
Follow-up Tasks
Multiprovider should be removed from the contrib codebase