fix(config-cat): Rework error reporting #1242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Simon <[email protected]>
beeme1mr
reviewed
Mar 26, 2025
Signed-off-by: Adam Simon <[email protected]>
|
Sorry for the delay @adams85, many of us were at KubeCon last week. |
|
Can we go ahead and merge this? |
|
Yes, looks good to me @adams85! |
This was referenced Apr 9, 2025
markphelps
pushed a commit
to flipt-io/js-sdk-contrib
that referenced
this pull request
Apr 10, 2025
Signed-off-by: Mark Phelps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Attempts to fix #1212 by reworking error reporting. (More on the reason for the change in the related issue.)
Related Issues
Fixes #1212
Notes
This PR is not meant to be a complete solution, more of a quick fix to the related issue. It should be revised and improved later.
Follow-up Tasks
n/a
How to test
n/a