-
Notifications
You must be signed in to change notification settings - Fork 22
feat(provider): add Unleash provider #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @kikihakiem, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request delivers a new OpenFeature provider specifically designed for Unleash, a popular feature management platform. Its primary purpose is to bridge the gap between OpenFeature's standardized API and Unleash's feature flagging capabilities for Python applications. This integration empowers developers to manage feature rollouts and experiments seamlessly, leveraging both OpenFeature's interoperability and Unleash's robust feature management features. The implementation is thorough, covering various flag types, event handling, and tracking, all backed by a comprehensive test suite.
Highlights
- New Provider Added: Introduced a new OpenFeature provider for Unleash, enabling Python applications to integrate with Unleash for feature flagging and experimentation.
- Community Request Fulfilled: This addition directly addresses community requests for OpenFeature support within the Unleash ecosystem.
- Comprehensive Functionality: The provider supports boolean, string, integer, float, and object flag types, along with OpenFeature event handling and tracking capabilities.
- Robust Testing: Includes extensive unit and integration tests, ensuring reliability and correctness of the Unleash provider.
- Development Tooling: New
pyproject.toml
entries and utility scripts are added to streamline development, testing, type checking, and linting workflows.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR adds a new Unleash provider for the OpenFeature Python SDK. The implementation is well-structured and includes a comprehensive set of unit and integration tests, which is great to see. I've left a few comments with suggestions for improvement, mainly around security best practices in helper scripts and removing some potentially unreachable error handling code for better maintainability. Overall, this is a solid contribution.
...ers/openfeature-provider-unleash/src/openfeature/contrib/provider/unleash/flag_evaluation.py
Outdated
Show resolved
Hide resolved
...ers/openfeature-provider-unleash/src/openfeature/contrib/provider/unleash/flag_evaluation.py
Outdated
Show resolved
Hide resolved
d5f7e81
to
9a579d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I think it's heading in the right direction, but from Unleash design perspective, there are a few things that should be done differently. I believe it's a relatively simple change that will make the provider much better.
...ers/openfeature-provider-unleash/src/openfeature/contrib/provider/unleash/flag_evaluation.py
Outdated
Show resolved
Hide resolved
...ers/openfeature-provider-unleash/src/openfeature/contrib/provider/unleash/flag_evaluation.py
Outdated
Show resolved
Hide resolved
providers/openfeature-provider-unleash/src/openfeature/contrib/provider/unleash/__init__.py
Outdated
Show resolved
Hide resolved
...ers/openfeature-provider-unleash/src/openfeature/contrib/provider/unleash/flag_evaluation.py
Outdated
Show resolved
Hide resolved
01b3e09
to
048029b
Compare
7e02cb3
to
4133039
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
- Coverage 94.41% 93.58% -0.84%
==========================================
Files 21 4 -17
Lines 1057 187 -870
==========================================
- Hits 998 175 -823
+ Misses 59 12 -47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
…eger_details, resolve_float_details and resolve_object_details Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
4133039
to
3d1fde8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is looking very good, I'm just a bit confused about the tracking stuff. Maybe you can share more details about this. If it wasn't for that, I'd be ok with this (i.e. if you were to remove tracking, then this would be a good solution from my perspective)
providers/openfeature-provider-unleash/src/openfeature/contrib/provider/unleash/__init__.py
Outdated
Show resolved
Hide resolved
...ers/openfeature-provider-unleash/src/openfeature/contrib/provider/unleash/flag_evaluation.py
Show resolved
Hide resolved
providers/openfeature-provider-unleash/src/openfeature/contrib/provider/unleash/tracking.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
This PR
Adds Unleash Provider for OpenFeature Python SDK
Related Issues
Fixes #300
Fixes #3896 - Addresses community request for OpenFeature support in Unleash ecosystem
Notes
Follow-up Tasks
How to test
uv sync
uv run test -m "not integration"
uv run test -m integration
uv run mypy-check
uv run ruff check