Skip to content

Conversation

kikihakiem
Copy link

This PR

Adds Unleash Provider for OpenFeature Python SDK

Related Issues

Fixes #300
Fixes #3896 - Addresses community request for OpenFeature support in Unleash ecosystem

Notes

Follow-up Tasks

How to test

  1. Install dependencies: uv sync
  2. Run unit tests: uv run test -m "not integration"
  3. Run integration tests (requires Docker): uv run test -m integration
  4. Run type checking: uv run mypy-check
  5. Run linting: uv run ruff check

@kikihakiem kikihakiem requested review from a team as code owners September 2, 2025 08:14
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @kikihakiem, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a new OpenFeature provider specifically designed for Unleash, a popular feature management platform. Its primary purpose is to bridge the gap between OpenFeature's standardized API and Unleash's feature flagging capabilities for Python applications. This integration empowers developers to manage feature rollouts and experiments seamlessly, leveraging both OpenFeature's interoperability and Unleash's robust feature management features. The implementation is thorough, covering various flag types, event handling, and tracking, all backed by a comprehensive test suite.

Highlights

  • New Provider Added: Introduced a new OpenFeature provider for Unleash, enabling Python applications to integrate with Unleash for feature flagging and experimentation.
  • Community Request Fulfilled: This addition directly addresses community requests for OpenFeature support within the Unleash ecosystem.
  • Comprehensive Functionality: The provider supports boolean, string, integer, float, and object flag types, along with OpenFeature event handling and tracking capabilities.
  • Robust Testing: Includes extensive unit and integration tests, ensuring reliability and correctness of the Unleash provider.
  • Development Tooling: New pyproject.toml entries and utility scripts are added to streamline development, testing, type checking, and linting workflows.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR adds a new Unleash provider for the OpenFeature Python SDK. The implementation is well-structured and includes a comprehensive set of unit and integration tests, which is great to see. I've left a few comments with suggestions for improvement, mainly around security best practices in helper scripts and removing some potentially unreachable error handling code for better maintainability. Overall, this is a solid contribution.

@kikihakiem kikihakiem force-pushed the feat/unleash-provider branch from d5f7e81 to 9a579d6 Compare September 2, 2025 08:19
Copy link

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I think it's heading in the right direction, but from Unleash design perspective, there are a few things that should be done differently. I believe it's a relatively simple change that will make the provider much better.

@kikihakiem kikihakiem force-pushed the feat/unleash-provider branch from 01b3e09 to 048029b Compare September 3, 2025 07:57
@kikihakiem kikihakiem force-pushed the feat/unleash-provider branch 4 times, most recently from 7e02cb3 to 4133039 Compare September 10, 2025 12:28
Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 93.58289% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.58%. Comparing base (9590554) to head (4133039).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...eature/contrib/provider/unleash/flag_evaluation.py 86.53% 7 Missing ⚠️
...c/openfeature/contrib/provider/unleash/__init__.py 95.12% 4 Missing ⚠️
...c/openfeature/contrib/provider/unleash/tracking.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   94.41%   93.58%   -0.84%     
==========================================
  Files          21        4      -17     
  Lines        1057      187     -870     
==========================================
- Hits          998      175     -823     
+ Misses         59       12      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Kiki L Hakiem <[email protected]>
…eger_details, resolve_float_details and resolve_object_details

Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Signed-off-by: Kiki L Hakiem <[email protected]>
Copy link

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is looking very good, I'm just a bit confused about the tracking stuff. Maybe you can share more details about this. If it wasn't for that, I'd be ok with this (i.e. if you were to remove tracking, then this would be a good solution from my perspective)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[provider] Support Unleash provider
2 participants