Fix: widen MotionLayerState stat counters from uint32 to uint64#366
Merged
NJrslv merged 1 commit intoOPENGPDB_STABLEfrom Mar 31, 2026
Merged
Fix: widen MotionLayerState stat counters from uint32 to uint64#366NJrslv merged 1 commit intoOPENGPDB_STABLEfrom
NJrslv merged 1 commit intoOPENGPDB_STABLEfrom
Conversation
MotionLayerState accumulates stats across all MotionNodeEntry instances. Per-node entries already use uint64 [0]. The global sum ≥ any individual node, so it overflows first — at 4GB. Fix by widening to uint64. Also fix the debug elog() format specifiers to match. [0] https://github.com/open-gpdb/gpdb/blob/e0db8c33c80117241f88cecca225c9fcd39dd28f/src/include/cdb/cdbinterconnect.h#L498
reshke
approved these changes
Mar 30, 2026
NJrslv
added a commit
that referenced
this pull request
Mar 31, 2026
MotionLayerState accumulates stats across all MotionNodeEntry instances. Per-node entries already use uint64 [0]. The global sum ≥ any individual node, so it overflows first — at 4GB. Fix by widening to uint64. Also fix the debug elog() format specifiers to match. [0] https://github.com/open-gpdb/gpdb/blob/e0db8c33c80117241f88cecca225c9fcd39dd28f/src/include/cdb/cdbinterconnect.h#L498
NJrslv
added a commit
that referenced
this pull request
Mar 31, 2026
MotionLayerState accumulates stats across all MotionNodeEntry instances. Per-node entries already use uint64 [0]. The global sum ≥ any individual node, so it overflows first — at 4GB. Fix by widening to uint64. Also fix the debug elog() format specifiers to match. [0] https://github.com/open-gpdb/gpdb/blob/e0db8c33c80117241f88cecca225c9fcd39dd28f/src/include/cdb/cdbinterconnect.h#L498
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MotionLayerState accumulates stats across all MotionNodeEntry instances.
Per-node entries already use uint64 [0]. The global sum ≥ any individual node,
so it overflows first — at 4GB. Fix by widening to uint64.
Also fix the debug elog() format specifiers to match.
[0]
gpdb/src/include/cdb/cdbinterconnect.h
Line 498 in e0db8c3