Skip to content

Issue 666 - move file, other minor updates#696

Merged
euconnor merged 1 commit intoopen-horizon:masterfrom
euconnor:issue-666
Apr 2, 2026
Merged

Issue 666 - move file, other minor updates#696
euconnor merged 1 commit intoopen-horizon:masterfrom
euconnor:issue-666

Conversation

@euconnor
Copy link
Copy Markdown
Contributor

Pull Request Template

Description

Moved the Using Custom Sample Services topic to a more appropriate location. Made a few other minor updates.

Fixes #666. This PR is in addition to PR 695.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Not possible to fully test until published.

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [n/a] I have made corresponding changes to the documentation
  • [n/a] My changes generate no new warnings
  • [n/a] I have added tests that prove my fix is effective or that my feature works
  • [n/a] New and existing unit tests pass locally with my changes
  • [n/a] Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • [?] I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

Will ask @joewxboy and @t-fine to review.

Signed-off-by: Eugene O'Connor <euconnor@ie.ibm.com>
@euconnor euconnor requested a review from t-fine March 31, 2026 09:35
@euconnor
Copy link
Copy Markdown
Contributor Author

Hi @t-fine. Can you review the changes I made for Using Custom Sample Services (issue 666)? In particular, can you answer the following two questions?

  1. Do we need anything to state which ORG_ID the BYO Samples are published into? (That one is from @joewxboy)
  2. IN your example in PR 619, you included this environment variable:
- export OH_EXAMPLES_REPO=https://raw.githubusercontent.com/t-fine/examples/refs/heads/feat_611_byo_blessed_samples

Is that required?
The main topic to review is custom_samples.md.
Joe has already reviewed most of the changes.

Copy link
Copy Markdown

@t-fine t-fine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@euconnor euconnor merged commit 35d4462 into open-horizon:master Apr 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation📄: Add information about blessed samples/adding your own examples

2 participants