-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looker parsing improvements for liquid templating and view/model aliasing #17912
base: main
Are you sure you want to change the base?
Looker parsing improvements for liquid templating and view/model aliasing #17912
Conversation
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
@sam-mccarty-mavenclinic thanks for the contribution |
@harshach no problem, i was making some tweaks to see if i could get the lineage fixed for our specific looker implementation, but i am open to more generic approaches to these issues if this initial solution is a bit too opinionated |
Hi @sam-mccarty-mavenclinic, thank you for the PR.
E ModuleNotFoundError: No module named 'liquid'
|
One sec, I will push a fix to the setup file. Happy to add a test with sample file with the templating included, can you point me to the right location to add my test? |
Take a look here. |
6342464
to
afcc12d
Compare
I would like to propose two improvements to resolve issues with Looker ingestion, one with liquid template variables in sql_table_name and another with aliased views and explores
Describe your changes:
Fixes #17911
from_
attribute for views to replace thename
while building the lineage to correctly map to the actual view being joinedview_name
on the model so that the underlying view it is based on is included as part of the lineage, regardless of whether there are other views joinedType of change:
Checklist:
Fixes <issue-number>: <short explanation>