Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding an icon for docs and API link #196

Merged
merged 1 commit into from
Aug 16, 2021
Merged

adding an icon for docs and API link #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions catalog-rest-service/src/main/resources/ui/src/assets/svg/api.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions catalog-rest-service/src/main/resources/ui/src/assets/svg/doc.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
14 changes: 12 additions & 2 deletions catalog-rest-service/src/main/resources/ui/src/components/app-bar/Appbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,12 @@ const Appbar: React.FC = (): JSX.Element => {
to={{
pathname: 'https://docs.open-metadata.org/',
}}>
{/* <i className="fas fa-file-alt tw-pr-2" /> */}
<SVGIcons
alt="Doc icon"
className="tw-align-middle tw--mt-0.5 tw-mr-0.5"
icon="doc"
width="12"
/>
<span>Docs</span>
</NavLink>
<NavLink
Expand All @@ -149,7 +154,12 @@ const Appbar: React.FC = (): JSX.Element => {
to={{
pathname: '/docs',
}}>
{/* <i className="fas fa-sitemap tw-pr-2" /> */}
<SVGIcons
alt="API icon"
className="tw-align-middle tw--mt-0.5 tw-mr-0.5"
icon="api"
width="12"
/>
<span>API</span>
</NavLink>
<div data-testid="dropdown-profile">
Expand Down
12 changes: 12 additions & 0 deletions catalog-rest-service/src/main/resources/ui/src/utils/SvgUtils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import React, { FunctionComponent } from 'react';
import IconGoogle from '../assets/img/google-icon.png';
import IconAPI from '../assets/svg/api.svg';
import IconSuccess from '../assets/svg/check.svg';
import IconAsstest from '../assets/svg/data-assets.svg';
import IconDoc from '../assets/svg/doc.svg';
import IconError from '../assets/svg/error.svg';
import IconCheckCircle from '../assets/svg/ic-check-circle.svg';
import IconDelete from '../assets/svg/ic-delete.svg';
Expand Down Expand Up @@ -100,6 +102,8 @@ export const Icons = {
SERVICE: 'service',
USERS: 'users',
TERMS: 'terms',
DOC: 'doc',
API: 'api',
};

const SVGIcons: FunctionComponent<Props> = ({
Expand Down Expand Up @@ -297,6 +301,14 @@ const SVGIcons: FunctionComponent<Props> = ({
case Icons.TERMS:
IconComponent = IconTerns;

break;
case Icons.DOC:
IconComponent = IconDoc;

break;
case Icons.API:
IconComponent = IconAPI;

break;

default:
Expand Down