Scim Interface and resource in OM #21512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aji-aju
added
safe to test
There was a problem hiding this comment.
Pull Request Overview
This PR integrates SCIM provisioning into OpenMetadata by adding new configuration settings, API schemas, and resource endpoints while extending existing entity schemas to support SCIM-related attributes.
- Adds a new SCIM configuration schema and integrates it into the settings JSON.
- Extends user and team JSON schemas with an externalId field for identity provider integration.
- Introduces new SCIM API schemas, endpoints, and a default provisioning service with unimplemented stub functions.
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| openmetadata-spec/src/main/resources/json/schema/settings/settings.json | Added "scimConfiguration" to the settings array. |
| openmetadata-spec/src/main/resources/json/schema/scim/scimConfiguration.json | New schema for SCIM configuration. |
| openmetadata-spec/src/main/resources/json/schema/entity/teams/user.json | Added externalId field to user schema. |
| openmetadata-spec/src/main/resources/json/schema/entity/teams/team.json | Added externalId field to team schema. |
| openmetadata-spec/src/main/resources/json/schema/api/teams/createUser.json | Extended schema to include externalId for users. |
| openmetadata-spec/src/main/resources/json/schema/api/teams/createTeam.json | Extended schema to include externalId for teams. |
| openmetadata-spec/src/main/resources/json/schema/api/scim/scimUser.json | New SCIM User schema. |
| openmetadata-spec/src/main/resources/json/schema/api/scim/scimPatchOp.json | New SCIM PatchOp schema. |
| openmetadata-spec/src/main/resources/json/schema/api/scim/scimGroup.json | New SCIM Group schema. |
| openmetadata-service/src/main/java/org/openmetadata/service/security/SecurityUtil.java | Integrated SCIM configuration check in user name extraction and added isBotW helper. |
| openmetadata-service/src/main/java/org/openmetadata/service/scim/impl/DefaultScimProvisioningService.java | Introduced a default SCIM provisioning service returning not-implemented responses. |
| openmetadata-service/src/main/java/org/openmetadata/service/scim/ScimProvisioningService.java | New interface for SCIM provisioning. |
| openmetadata-service/src/main/java/org/openmetadata/service/resources/scim/ScimResource.java | Added new SCIM endpoints supporting user and group provisioning. |
| Other integration files (SettingsCache, SystemRepository, CollectionDAO, OpenMetadataApplicationConfig, OpenMetadataApplication) | Updated to include SCIM configuration and register the new SCIM resource. |
Comments suppressed due to low confidence (1)
openmetadata-spec/src/main/resources/json/schema/api/scim/scimPatchOp.json:16
- The property name 'Operations' is capitalized while other SCIM schema properties use lower-case. Consider renaming it to 'operations' for consistency.
"Operations": {
Jest test CoverageUI tests summary
|
aji-aju
changed the title
|
|
harshach
previously approved these changes
Jun 10, 2025
mohityadav766
approved these changes
Jun 13, 2025
|
Scim Resource Test @aji-aju will handle in a different PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>