Aws prw exporter #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'add-aws-cortex-exporter' of github.com:open-o11y/opentelemetry-collector-contrib into add-aws-cortex-exporter
PettitWesley
approved these changes
Nov 13, 2020
rakyll
reviewed
Nov 13, 2020
| prw "go.opentelemetry.io/collector/exporter/prometheusremotewriteexporter" | ||
| ) | ||
|
|
||
| const ( |
There was a problem hiding this comment.
You can remove the grouping here when there is only one const:
const typeStr = "awsprometheusremotewrite" // The value of "type" key in configuration.
| "go.uber.org/zap" | ||
| ) | ||
|
|
||
| func Test_Type(t *testing.T) { |
There was a problem hiding this comment.
TestType
_ is used often for different flavors of testing for the same. For example:
TestType_edcase1
TestType_edcase2
| } | ||
|
|
||
| //Tests whether or not the default Exporter factory can instantiate a properly interfaced Exporter with default conditions | ||
| func Test_CreateDefaultConfig(t *testing.T) { |
| } | ||
|
|
||
| //Tests whether or not a correct Metrics Exporter from the default Config parameters | ||
| func Test_CreateMetricsExporter(t *testing.T) { |
| return cfg | ||
| } | ||
|
|
||
| func validateAuthConfig(params AuthSettings) bool { |
There was a problem hiding this comment.
I'd rename this to isAuthSettingsValid.
rakyll
approved these changes
Nov 13, 2020
|
All comments have been resolved and PR has been merged upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a new exporter that leverages the existing Prometheus Remote Write Exporter in the core collector repo, and adds AWS Sigv4 authentication logic to it.
The idea here is to add an interceptor to the http client that is used to initialize the Prometheus Remote Write Exporter struct. The interceptor handles the Sigv4 logic, and the rest of the logic is identical to the core exporter.
The way this is designed, any changes in the core exporter's config will need to be duplicated here, however any other changes in the core exporter should be fine.
This PRs size is significantly bloated by the go summary file
Link to tracking Issue:
No direct issue for this exists but it is related to vendor specific code discussion: open-telemetry/oteps#141
Testing:
Unit tests have been added for the factory and config. Testing the authentication logic has been done manually by setting up a pipeline to communicate with AWS services.
Documentation:
A thorough
README.mdis included, as well as all example configuration intestdata/config.yaml