-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Opentelemetry issue#1699 #68
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be fine merging this as-is, but think it could be improved as noted in the comment below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IrisTuntun as we discussed pl fix PR title to be more descriptive and update PR description to itemize what was fixed along with tests added.
Fixes open-telemetry#1699
testCollectorEnpoint
totestCollectorEndpoint
.gen.Batch
that was exported.Note:
gen.Batch
has already been recorded intestCollectorEndpoint
thanks to open-telemetry#1693