Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Opentelemetry issue#1699 #68

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

IrisTuntun
Copy link

Fixes open-telemetry#1699

  1. Fixed the typo testCollectorEnpoint to testCollectorEndpoint.
  2. Added assertions on process tags in gen.Batch that was exported.

Note: gen.Batch has already been recorded in testCollectorEndpoint thanks to open-telemetry#1693

@codecov-io
Copy link

codecov-io commented Mar 27, 2021

Codecov Report

Merging #68 (a20fa94) into main (382c7ce) will increase coverage by 38.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main     #68      +/-   ##
========================================
+ Coverage   39.9%   78.0%   +38.0%     
========================================
  Files        178     131      -47     
  Lines      13954    6953    -7001     
========================================
- Hits        5571    5424     -147     
+ Misses      8026    1279    -6747     
+ Partials     357     250     -107     
Impacted Files Coverage Δ
..._party/thrift/lib/go/thrift/transport_exception.go
...ters/trace/jaeger/internal/gen-go/jaeger/jaeger.go
...nal/third_party/thrift/lib/go/thrift/serializer.go
...third_party/thrift/lib/go/thrift/rich_transport.go
...arty/thrift/lib/go/thrift/application_exception.go
...ird_party/thrift/lib/go/thrift/framed_transport.go
...l/third_party/thrift/lib/go/thrift/deserializer.go
...orters/trace/jaeger/internal/gen-go/agent/agent.go
...ernal/third_party/thrift/lib/go/thrift/protocol.go
.../third_party/thrift/lib/go/thrift/configuration.go
... and 37 more

Copy link

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be fine merging this as-is, but think it could be improved as noted in the comment below.

exporters/trace/jaeger/jaeger_test.go Outdated Show resolved Hide resolved
Copy link

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IrisTuntun as we discussed pl fix PR title to be more descriptive and update PR description to itemize what was fixed along with tests added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test exporting a batch of spans from Jaeger Exporter is working as expected
4 participants