Skip to content

fix: benchmark unit conversions and formatting #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shomron wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: benchmark unit conversions and formatting #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86fb2b9
fix: benchmark unit conversions and formatting
shomron Sep 11, 2025
52b9542
Merge branch 'main' into fix-bench-units
shomron Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions Sources/CLI/Duration+Format.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,25 +47,21 @@ struct NanosecondsDurationStyle: FormatStyle, Sendable {
}

private let attosecondsPerSecond = Double(1e18)
private let nanosecondsPerSecond = Double(1e9)
private let microsecondsPerSecond = Double(1e6)
private let millisecondsPerSecond = Double(1e3)

private let nanosecondsPerAtto = Double(1e9)
private let microsecondsPerAtto = Double(1e12)
private let millisecondsPerAtto = Double(1e15)
private let attosecondsPerNanosecond = Double(1e9)
private let attosecondsPerMicrosecond = Double(1e12)
private let attosecondsPerMillisecond = Double(1e15)

extension Duration {
var seconds: Double {
return Double(self.components.attoseconds) / attosecondsPerSecond
}
var nanoseconds: Double {
return Double(self.components.attoseconds) / nanosecondsPerAtto
return Double(self.components.attoseconds) / attosecondsPerNanosecond
}
var microseconds: Double {
return Double(self.components.attoseconds) / microsecondsPerAtto
return Double(self.components.attoseconds) / attosecondsPerMicrosecond
}
var milliseconds: Double {
return Double(self.components.attoseconds) / millisecondsPerSecond
return Double(self.components.attoseconds) / attosecondsPerMillisecond
}
}
11 changes: 6 additions & 5 deletions Sources/CLI/Measure+Format.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,20 +27,21 @@ struct GobenchStyle: FormatStyle, Sendable {
// Figure out which units are closest
var value: String = ""
var unit: String = ""
let style: FloatingPointFormatStyle<Double> = .number.precision(.fractionLength(0...4))
if v.components.seconds >= 1 {
value = v.seconds.formatted(.number.precision(.fractionLength(0...4)))
value = v.seconds.formatted(style)
unit = "s/op"
} else if 1..<1000 ~= v.milliseconds {
value = v.milliseconds.formatted(.number.precision(.fractionLength(0...4)))
value = v.milliseconds.formatted(style)
unit = "ms/op"
} else if 1..<1000 ~= v.microseconds {
value = v.microseconds.formatted(.number.precision(.fractionLength(0...4)))
value = v.microseconds.formatted(style)
unit = "μs/op"
} else if 1..<1000 ~= v.nanoseconds {
value = v.nanoseconds.formatted(.number.precision(.fractionLength(0...4)))
value = v.nanoseconds.formatted(style)
unit = "ns/op"
} else {
value = v.components.attoseconds.formatted(.number.precision(.fractionLength(0...4)))
value = v.components.attoseconds.formatted(.number.grouping(.automatic))
unit = "as/op"
}
return "Benchmark\t\(report.iterations)\t\(value) \(unit)"
Expand Down