Optest sysinfo enhancement#918
Conversation
Output of SYSinfo Enhancementroot@ltczz219-lp6: [console-expect]#date [console-expect]#date [console-expect]#PS1=[console-expect]# [console-expect]# [console-expect]#date Ran 4 tests in 0.001s OK (skipped=4) Ran 1 test in 0.000s OK
|
c118f60 to
501d7e9
Compare
Latest Runroot@ltczz219-lp6: [console-expect]#date [console-expect]#date [console-expect]#PS1=[console-expect]# [console-expect]# [console-expect]#date The following resources are installed on the machine.
Model Architecture: chrp
Ran 4 tests in 0.000s OK (skipped=4) Ran 1 test in 0.000s OK
|
501d7e9 to
9576f93
Compare
CONFIG.YAML
Outdated
| FS: | ||
| COMMANDS: | ||
| - "mkfs.ext4 -V" | ||
| - "mkfs.xfs -V" |
There was a problem hiding this comment.
This is part of LINUX section
There was a problem hiding this comment.
The reason I made is If we look at the file it looks like component is covered
There was a problem hiding this comment.
ok .. but i feel we have sysinfo covered as stack .. so fs memory will be lies on the LINUX component
CONFIG.YAML
Outdated
| COMMANDS: | ||
| - "lshwres -r io -m SYS --rsubtype slot --filter 'lpar_names=LPAR_NAME'" # List physical IO | ||
| - "lshwres -r virtualio --rsubtype fc --level lpar -m SYS -F adapter_type,lpar_name,slot_num,remote_lpar_name,remote_slot_num,wwpns" # List virtual IOs | ||
|
|
There was a problem hiding this comment.
ideally it should be part of HMC
There was a problem hiding this comment.
The reason I made is If we look at the file it looks like component is covered
There was a problem hiding this comment.
for USER i feel it's just a command section .. Component mapping can be done based on individual
common/OpTestHMC.py
Outdated
| log.info("Collecting HMC details") | ||
| self.sysinfo.get_HMCconfig(self.ssh, self.expect_prompt,self.mg_system) | ||
| self.sysinfo.get_config(self.ssh, self.expect_prompt,self.mg_system,self.lpar_name,'HMC') | ||
| log.info("Collecting IO details") |
There was a problem hiding this comment.
If you see here before calling component I am telling in log.info statement about component it would possible only as per my CONFIG.YAML
There was a problem hiding this comment.
Yes, I saw. Instead of hard-coding and changing the py file for every component request, it's not good. Let's have something simple like any framework op-test, sysinfo only has scope to support legitimate commands that can run. The broader category make more sense here
|
@yeswanth6096 I see |
i see this way it user-driven.. so i feel we should not deep dive how the command looks .. |
9576f93 to
15e56ca
Compare
Signed-off-by: yeswanth <yeswanth@linux.ibm.com>
15e56ca to
68bfb97
Compare
|
Deleted few commands and addressed comments |
@PraveenPenguin
@abdhaleegit