Skip to content

Conversation

nikhilbhatia08
Copy link
Contributor

Fixes #2085

Using this change we can get max_queue_size schedule_delay export_timeout max_export_batch_size using environment variables. BatchSpanProcessor still does not use export_timeout and tests have been added.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@nikhilbhatia08 nikhilbhatia08 requested a review from a team as a code owner September 25, 2025 20:26
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (ecb155b) to head (f42ac79).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3661      +/-   ##
==========================================
+ Coverage   90.11%   90.18%   +0.07%     
==========================================
  Files         221      222       +1     
  Lines        7135     7154      +19     
==========================================
+ Hits         6429     6451      +22     
+ Misses        706      703       -3     
Files with missing lines Coverage Δ
sdk/src/trace/batch_span_processor_options.cc 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed:

The header file exposes implementation details, which are compiled into the application binary.

Move every implementation details, including default values, helpers, names of environment variables, to batch_span_processor_options.cc

See existing options structures for the pattern.

@nikhilbhatia08
Copy link
Contributor Author

@marcalff Applied the above changes, Thanks! But the BatchSpanProcessor does not have the field of export_timeout so it would be another issue for implementing it in BatchSpanProcessor ?

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much better.

See minor cleanup,
I will approve once I can verify the changes.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TRACE SDK] Batch Span Processor options not using environment variables
3 participants