An example / proof of concept for stratified sampling in OpenTelemetry.NET #4208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4208 +/- ##
==========================================
+ Coverage 83.27% 84.72% +1.44%
==========================================
Files 296 295 -1
Lines 11685 11475 -210
==========================================
- Hits 9731 9722 -9
+ Misses 1954 1753 -201
|
cijothomas
reviewed
Feb 22, 2023
cijothomas
reviewed
Feb 22, 2023
….com/kalyanaj/opentelemetry-dotnet into kalyanaj-stratified-sampling-example
docs/trace/advanced/stratified-sampling-example/stratified-sampling-example.csproj
Outdated
Show resolved
Hide resolved
yurishkuro
reviewed
Feb 22, 2023
…pling-example.csproj Co-authored-by: Timothy Mothra <[email protected]>
cijothomas
reviewed
Mar 2, 2023
cijothomas
reviewed
Mar 2, 2023
cijothomas
reviewed
Mar 2, 2023
docs/trace/advanced/stratified-sampling-example/stratified-sampling-example.csproj
Outdated
Show resolved
Hide resolved
cijothomas
approved these changes
Mar 2, 2023
|
@utpilla one more person proof reading would be good before merge. |
jmacd
reviewed
Mar 2, 2023
utpilla
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example / proof of concept for a basic stratified sampling in OpenTelemetry.NET.
Fixes #4207
Changes
Certain customers using OpenTelemetry want to do achieve stratified sampling. Stratified sampling is a way to divide a population (e.g., "all queries to a service") into mutually exclusive sub-populations aka "strata". For example, the strata here could be "all user-initiated queries", "all programmatic queries". Each stratum is then sampled using a probabilistic sampling method. This ensures that all sub-populations are represented.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes