metrics: add an interface to get the metrics definitions #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixge
approved these changes
Sep 13, 2024
Comment on lines
+168
to
+172
| err := dec.Decode(&definitions) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return definitions, nil |
There was a problem hiding this comment.
NIT: This could be simplified:
Suggested change
| err := dec.Decode(&definitions) | |
| if err != nil { | |
| return nil, err | |
| } | |
| return definitions, nil | |
| return definitions, dec.Decode(&definitions) |
There was a problem hiding this comment.
IIUC, unfortunately this linter rule disallows this: https://go-critic.com/overview.html#evalorder
florianl
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149
This will enable profilers using the ebpf profiler as a library to export some of the internal metrics of the profiler. For example, this should allow getting more data on unwinding errors for interpreted languages.
For the interface, I added a
GetDefinitions()method in the metrics package, which would require exposing themetricspackage in #132, happy to move this elsewhere though if we think this is not the best place / API for this.