Hotspot tests: mock process memory reading #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The real deal doesn't work if the test executable is running under qemu-user emulation.
florianl
approved these changes
Jul 10, 2024
rockdaboot
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TestJavaSymbolExtractiontest would previously fail when running under qemu-user: if the application is running under emulation, the pointer addresses don't actually correspond to real memory addresses, so if the applications peeks through the curtains of emulation viaprocess_vm_read, it would read back the wrong values. This PR replaces the real memory read with a mocked one from an array.(Revived version of #73 that got auto-closed due to #76)