-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: support HeadersList #6657
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6657 +/- ##
=====================================
Coverage 75.5% 75.6%
=====================================
Files 207 207
Lines 19152 19186 +34
=====================================
+ Hits 14475 14506 +31
- Misses 4241 4243 +2
- Partials 436 437 +1
|
@codeboten, PTAL as a codeowner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about updating these two files:
config/testdata/v0.3.yaml
config/testdata/v0.3.json
so that they include the new supported fields?
Co-authored-by: Robert Pająk <[email protected]>
They already are in the config files but so far have been unsupported by the code. That’s what inspired me to create this PR in the first place |
Looks goods 👍 Please resolve the conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mattsains!
Fixes #6351