-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring boot runtime metrics #13078
Closed
zeitlinger
wants to merge
20
commits into
open-telemetry:main
from
zeitlinger:spring-boot-runtime-metrics
Closed
Spring boot runtime metrics #13078
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d0d45ec
spring boot runtime metrics for java 17+
zeitlinger 6d34a19
spring boot runtime metrics for java 8
zeitlinger c68df50
spring boot runtime metrics for java 8
zeitlinger 38941cf
fix native
zeitlinger c667920
use spring shutdown hook
zeitlinger 5b7548a
disable threads
zeitlinger b15e5cb
disable threads
zeitlinger a9a2262
test more metric types
zeitlinger 56f4b84
add metadata
zeitlinger 5762f4b
fix jfr and native image
zeitlinger dc49142
fix jfr and native image
zeitlinger 61fe87f
review
zeitlinger 4b91576
test more metrics
zeitlinger 2cf304e
improve assertions by showing the last result on a timeout
zeitlinger e057797
test more metrics
zeitlinger 466b16d
format
zeitlinger c927ceb
use newer graalvm
zeitlinger 5a82c35
Revert "improve assertions by showing the last result on a timeout"
zeitlinger 12e9dc5
init at build time
zeitlinger 13512c0
init at build time
zeitlinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
disable threads
- Loading branch information
commit b15e5cb84a7e888cd29b7b876db7ac8329f678ec
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that GraalVM Native Image would work fine with
Threads::java8Callback
. Native Image implements someThreadMXBean
functionality, notably all the functionality needed byThreads::java8Callback
(see here and here). Although,Threads::java9AndNewerCallback
still won't work with Native Image since we don't supportThreadMXBean#getAllThreadIds()
orThreadMXBean.getThreadInfo()
yet.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried JMX - and ran into #13078 (comment)