Update instrumentation docs with db client metrics #13080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Jan 22, 2025
docs/supported-libraries.md
Outdated
| | [Couchbase Client](https://github.com/couchbase/couchbase-java-client) | 2.0 - 2.7.x,<br>3.1+ | N/A | [Database Client Spans] | | ||
| | [Cassandra Driver](https://github.com/datastax/java-driver) | 3.0+ | [opentelemetry-cassandra-4.4](../instrumentation/cassandra/cassandra-4.4/library) | [Database Client Spans], [Database Client Metrics] | | ||
| | [Clickhouse Client](https://github.com/ClickHouse/clickhouse-java) | 0.5+ | N/A | [Database Client Spans], [Database Client Metrics] | | ||
| | [Couchbase Client](https://github.com/couchbase/couchbase-java-client) | 2.0 - 2.7.x,<br>3.1+ | N/A | [Database Client Spans], [Database Client Metrics] | |
There was a problem hiding this comment.
idk if this is worth mentioning here but with couchbase we have 2 instrumentations that generate different telemetry. The one for 3.x that uses tracing built into couchbase does not capture database metrics.
laurit
approved these changes
Jan 22, 2025
laurit
reviewed
Jan 22, 2025
docs/supported-libraries.md
Outdated
| @@ -48,9 +48,9 @@ These are the supported libraries and frameworks: | |||
| | [AWS Lambda](https://docs.aws.amazon.com/lambda/latest/dg/java-handler.html) | 1.0+ | [opentelemetry-aws-lambda-core-1.0](../instrumentation/aws-lambda/aws-lambda-core-1.0/library),<br>[opentelemetry-aws-lambda-events-2.2](../instrumentation/aws-lambda/aws-lambda-events-2.2/library) | [FaaS Server Spans] | | |||
| | [AWS SDK](https://aws.amazon.com/sdk-for-java/) | 1.11 - 1.12.583,<br>2.2+ | [opentelemetry-aws-sdk-1.11](../instrumentation/aws-sdk/aws-sdk-1.11/library),<br>[opentelemetry-aws-sdk-1.11-autoconfigure](../instrumentation/aws-sdk/aws-sdk-1.11/library-autoconfigure),<br>[opentelemetry-aws-sdk-2.2](../instrumentation/aws-sdk/aws-sdk-2.2/library),<br>[opentelemetry-aws-sdk-2.2-autoconfigure](../instrumentation/aws-sdk/aws-sdk-2.2/library-autoconfigure) | [Messaging Spans], [Database Client Spans], [HTTP Client Spans] | | |||
There was a problem hiding this comment.
i think this one also has db client metrics
zeitlinger
approved these changes
Jan 22, 2025
steverao
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12802 #12608 and #594
or should this wait until it is marked stable?