-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AttributeKeyValue abstraction to common otlp exporters #7026
Conversation
Initial use case for this more flexible behaviour is profiles requirement to pack N Alternatively the existing |
Key bits of context for me that we talked about in slack:
So this PR establishes the I dug up a conversation from 3/2024 where we talked about this exact thing: #6374 (comment) |
...ers/otlp/common/src/main/java/io/opentelemetry/exporter/internal/otlp/AttributeKeyValue.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment here on context for this PR, since it may not be entirely clear why this is necessary by looking at the code.
1bd6c4e
to
5df2376
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7026 +/- ##
============================================
- Coverage 89.95% 89.90% -0.05%
- Complexity 6636 6641 +5
============================================
Files 745 747 +2
Lines 20010 20029 +19
Branches 1962 1962
============================================
+ Hits 17999 18007 +8
- Misses 1415 1426 +11
Partials 596 596 ☔ View full report in Codecov by Sentry. |
Allows individual
Attributes
entries (Key/Value tuples) to be represented separately from anAttributes
collection and marshalled to OTLP from e.g.List
rather thanAttributes
(i.e.Map
).