Update to latest unreleased opentelemetry-configuration #7861
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7861 +/- ##
============================================
- Coverage 90.10% 90.05% -0.05%
- Complexity 7240 7338 +98
============================================
Files 825 826 +1
Lines 21850 22133 +283
Branches 2136 2206 +70
============================================
+ Hits 19688 19932 +244
- Misses 1496 1511 +15
- Partials 666 690 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I also want to add support for open-telemetry/opentelemetry-configuration#376 |
|
Thanks for the pointer @zeitlinger - this PR allows parsing them but doesn't update I'm not sure if we would first do that before updating configuration, or do it together, happy to go with any approach. |
it was deprecated because it had a different meaning
I think it's fine to the change together - happy to help out |
|
Thanks @zeitlinger - IIUC, there is currently no knob for the labels either If the knobs were already there, wiring them into declarative config would be simple, but if we need to add (or restore) new ones, I guess we should use a separate PR since they're for public API? |
correct
I think it doesn't matter if it's public API, because we would document it either way - but a separate PR is also fine |
| .getAdditionalProperties() | ||
| .compute("otlp_file/development", (k, v) -> model.getOtlpFileDevelopment()); | ||
| model.getAdditionalProperties().compute("console", (k, v) -> model.getConsole()); | ||
| String key = null; |
There was a problem hiding this comment.
ha this is a little more clear huh?
| String key = null; | ||
| Object value = null; | ||
| if (model.getJaegerRemoteDevelopment() != null) { | ||
| key = "jaeger_remote/development"; |
| resource = model.getOtlpHttp(); | ||
| } | ||
| if (model.getOtlpGrpc() != null) { | ||
| requireNullResource(resource, RESOURCE_NAME, model.getAdditionalProperties()); |
There was a problem hiding this comment.
Adding strictness here to fail fast?
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Thanks a lot, looks good! Can't merge it until opentelemetry-configuration cuts a release, but we can use this as a working branch.
3 participants
I was curious if I can update config to start implementing the composite samplers in file config and little did I realize what I was getting myself into ;) But having started, went ahead and chugged through it. Not sure what the right time for this is so will leave it in draft but let me know whenever we should go forward with it, or also feel free to do an initial review even while draft if desired. /cc @jack-berg