feat: apply rule @typescript-eslint/explicit-member-accessibility

[legendecas]

Which problem is this PR solving?

• Identifying pitfalls like fix(instrumentation-openai)!: add missing access modifiers to private methods #3242 earlier.

Short description of the changes

Given that applying the private access modifier could be a potential breaking change, this does not apply the rule to every package to reduce the burden of reviewers.

• Apply rule @typescript-eslint/explicit-member-accessibility to (non-instrumentation) packages (less changes).

[github-actions]

This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature.
Are you familiar with this package? Consider becoming a component owner.

[JamieDanielson]

Nice cleanup, looks like those constants aren't used here and are already being exported in utils.

[JamieDanielson]

Should this be marked as breaking since there are some private modifiers being added in where they weren't previously?

[pichlermarc]

Looks good overall, but I think we may have to undo the changes from public to private in packages/resource-detector-aws, as the package is already stable.

[legendecas]

There are _ prefixed methods in packages/resource-detector-aws with implicit public accessibility. Should we mark these methods as private?

opentelemetry-js-contrib/packages/resource-detector-aws/src/detectors/AwsBeanstalkDetector.ts

Line 92 in efc2c8d

async _gatherData(): Promise<DetectedResourceAttributes> {

[pichlermarc]

There are _ prefixed methods in packages/resource-detector-aws with implicit public accessibility. Should we mark these methods as private?

opentelemetry-js-contrib/packages/resource-detector-aws/src/detectors/AwsBeanstalkDetector.ts

Line 92 in efc2c8d

async _gatherData(): Promise<DetectedResourceAttributes> {

Looking into this again, it looks like the classes themselves are actually not exported. Only instances of it are, which makes adding private have less impact overall. So I think it'd be okay to describe this as a type-level bugfix use private here (current diff). 🙂

Note: I did this (making them as private) in #3242 because I knew it was an experimental package and it would end up in the breaking change section. I think the safest would be to use explicit public instead of private in this PR. Then in a second PR we can change methods that were intended as private methods to be actually private as a fix!:. This way the changelog will explicitly points it out as a breaking change. The version is then also auto-incremented as if we had merged a feat:. We could in that PR also leave the AWS detectors as-is (with the "incorrect" public modifiers) and wait for 3.0 to make them private.

Though I'm not convinced I would be worth the effort. So I'm actually okay with going as it is now 👍

[legendecas]

Actually, I think it makes sense to revert the private on implicit fields. But I kept the _method as private.