Nginx Instrumentation crd #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
reviewed
Jun 19, 2023
| type Nginx struct { | ||
| // Image is a container image with Nginx SDK and auto-instrumentation. | ||
| // +optional | ||
| Image string `json:"image,omitempty"` |
There was a problem hiding this comment.
Is there already image for nginx instrumentation?
There was a problem hiding this comment.
Here's the Nginx Otel module: https://github.com/open-telemetry/opentelemetry-cpp-contrib/blob/main/instrumentation/nginx
There was a problem hiding this comment.
For Nginx autoinstrumentation, default image with the instrumentation libraries is the same as for Apache Httpd - autoinstrumentation-apache-httpd
|
The PR needs rebasing |
pavolloffay
approved these changes
Jun 26, 2023
| } | ||
| if r.Spec.Nginx.Resources.Limits == nil { | ||
| r.Spec.Nginx.Resources.Limits = corev1.ResourceList{ | ||
| corev1.ResourceCPU: resource.MustParse("500m"), |
There was a problem hiding this comment.
we should extract these to a constant and reuse for others.
chrlic
force-pushed
the
nginx-a17n-crd
branch
2 times, most recently
from
18b51fc to
a865360
Compare
|
rebased, reopenning |
pavolloffay
approved these changes
Jun 27, 2023
Merged
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Nginx Instrumentation crd * Nginx Instruemtnation crd * chloggen * typos * make generate crd * make bundle - crd * make bundle - versions * default resources * consts for resource settings * rename resource consts * rename resource consts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instrumentation crd for Nginx autoinstrumentation
Aside of standard fields, it contains two more:
In a nutshell, Nginx instrumentation follows similar methods to Apache HTTPD instrumentation.