-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement rule-based sampler #279
Conversation
to avoid future collision with an official rule-based sampler, change the name to something less likely to conflict.
I think this is ready for review now, @open-telemetry/php-approvers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay 🐌
I've been reading this as a reference point for the ComponentProvider configuration.
Maybe we could add .gitattributes
as well to reduce package size, but happy for that to be a follow up.
Ported rule-based sampler from https://github.com/Nevay/otel-sdk-contrib-sampler
Co-authored-by: Tobias Bachert [email protected]