Clarify when bucket_counts array may be empty #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current definition says: "The number of elements in bucket_counts array must be by one greater than the number of elements in explicit_bounds array." However, it also says "bucket_counts is an optional field", which means its length can be 0, which than in turn means the length of explicit_bounds must be -1, which is impossible. We clarify that it is a valid situation to have both bucket_counts and explicit_bounds arrays empty.
cijothomas
approved these changes
Feb 5, 2025
jmacd
approved these changes
Feb 10, 2025
reyang
approved these changes
Feb 10, 2025
jsuereth
approved these changes
Feb 11, 2025
|
Does this resolve open-telemetry/opentelemetry-specification/issues/3848? Should it be solved first? I am always unsure about the exact relationship between the proto and the data model |
@mx-psi this PR is only about the regular Histogram. open-telemetry/opentelemetry-specification#3848 is about Exponential Histogram. |
|
Ah, my bad, sorry |
jack-berg
reviewed
Feb 11, 2025
|
CC @open-telemetry/specs-metrics-approvers |
jack-berg
approved these changes
Feb 11, 2025
bogdandrutu
approved these changes
Feb 12, 2025
|
This was open for several days and appears to match the data model spec. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current definition says:
"The number of elements in bucket_counts array must be by one
greater than the number of elements in explicit_bounds array."
However, it also says "bucket_counts is an optional field", which
means its length can be 0, which then in turn means the length of
explicit_bounds must be -1, which is impossible.
We clarify that it is a valid situation to have both bucket_counts and explicit_bounds arrays empty.