Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Spelling: walkthroughs + workaround #6021

Merged
merged 2 commits into from
Jan 23, 2025
Merged

[chore] Spelling: walkthroughs + workaround #6021

merged 2 commits into from
Jan 23, 2025

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 22, 2025

@jsoref jsoref requested a review from a team as a code owner January 22, 2025 02:49
@opentelemetrybot opentelemetrybot requested review from a team and bogdandrutu and removed request for a team January 22, 2025 02:49
@chalin chalin mentioned this pull request Jan 23, 2025
Merged
chalin
chalin requested changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For an alternative, inspired by this PR, that adds textline rewrite rules and adds one more manual spelling fix, see:

jsoref added 2 commits January 22, 2025 22:14
@jsoref @chalin
spelling: walkthroughs
e619131 
Signed-off-by: Josh Soref <[email protected]>
@jsoref @chalin
spelling: workaround
42d29e2 
Signed-off-by: Josh Soref <[email protected]>
@opentelemetrybot opentelemetrybot requested review from a team January 23, 2025 03:14
@chalin
Copy link
Contributor

chalin commented Jan 23, 2025

Following @reyang's suggestion of accepting this PR then following through with #6036.

@chalin chalin merged commit b520443 into open-telemetry:main Jan 23, 2025
17 checks passed
@jsoref jsoref deleted the spelling-6 branch January 23, 2025 03:20
@jsoref jsoref mentioned this pull request Jan 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@chalin chalin chalin approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu was automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
blog sig:collector
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoref @chalin @reyang