Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Localize content java instrumentation #6085

Merged

Conversation

Vinaum8
Copy link
Contributor

@Vinaum8 Vinaum8 commented Jan 26, 2025

Link to: #5839

@Vinaum8 Vinaum8 requested a review from a team as a code owner January 26, 2025 16:14
@opentelemetrybot opentelemetrybot requested review from a team January 26, 2025 16:14
@Vinaum8
Copy link
Contributor Author

Vinaum8 commented Jan 26, 2025

/fix:htmltest-config

@svrnm svrnm changed the title Localize content java instrumentation [pt] Localize content java instrumentation Jan 27, 2025
Copy link
Contributor

@EzzioMoreira EzzioMoreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deixei algumas sugestões. Parabéns pelo trabalho @Vinaum8

@opentelemetrybot opentelemetrybot requested a review from a team January 27, 2025 12:25
@chalin
Copy link
Contributor

chalin commented Jan 31, 2025

Add the tag back once this PR is once again ready. Thx

@vitorvasc
Copy link
Member

There are link check errors:

========================================================================
running in concurrent mode, this is experimental
pt/docs/languages/java/instrumentation/index.html
  hash does not exist --- pt/docs/languages/java/instrumentation/index.html --> #zero-code-java-agent
  hash does not exist --- pt/docs/languages/java/instrumentation/index.html --> #zero-code-java-agent
  hash does not exist --- pt/docs/languages/java/instrumentation/index.html --> #zero-code-spring-boot-starter
  hitting --- pt/docs/languages/java/instrumentation/index.html --> https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/jmx-metrics/javaagent/LEIA-ME.md
  Non-OK status: 404 --- pt/docs/languages/java/instrumentation/index.html --> https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/jmx-metrics/javaagent/LEIA-ME.md
========================================================================

Hey, @chalin! Actually, we were just discussing about it on Slack.

Both the #zero-code-java-agent and #zero-code-spring-boot-starter do exist:

But, somehow, are broken on this PR. Could it be because of the : on the original text?

@chalin
Copy link
Contributor

chalin commented Jan 31, 2025

@vitorvasc - right, the hash IDs exist in the en version of the page, but not your pt version of the page.

You can validate this yourself in the preview: https://deploy-preview-6085--opentelemetry.netlify.app/pt/docs/languages/java/instrumentation/#zero-code-java-agent. E.g., inside the first alert, "Agente Java" goes nowhere. :)

@chalin
Copy link
Contributor

chalin commented Jan 31, 2025

Also, please rebase and resolve conflicts.

Co-authored-by: Vitor Vasconcellos <[email protected]>
@opentelemetrybot opentelemetrybot requested review from a team January 31, 2025 18:52
@chalin
Copy link
Contributor

chalin commented Jan 31, 2025

(I couldn't rebase from the web UI, so I tried a merge for now.)

@vitorvasc
Copy link
Member

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13079067843

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@Vinaum8
Copy link
Contributor Author

Vinaum8 commented Jan 31, 2025

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13081164571

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@chalin chalin added this pull request to the merge queue Feb 1, 2025
Merged via the queue into open-telemetry:main with commit 7440ace Feb 1, 2025
17 checks passed
@opentelemetrybot
Copy link
Collaborator

Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey

@Vinaum8 Vinaum8 deleted the localize-content-java-instrumentation branch February 1, 2025 15:03
@chalin
Copy link
Contributor

chalin commented Feb 3, 2025

Is this ready for final (non-pt) approval @open-telemetry/docs-pt-approvers? If so, please tag it with docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

10 participants