Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link fix of Spring Boot Starter other-spring-autoconfig.md #6199

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 4, 2025

The folder/package opentelemetry-spring-boot-autoconfigure doesn't seem to exist anymore. Also, the following link has an invalid hash, but in any case it points back to this website, so we should just refer directly to this website. WDYT @trask @open-telemetry/java-instrumentation-approvers?

[opentelemetry-spring-boot-autoconfigure](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/spring/spring-boot-autoconfigure/README.md#features?FIXME)

This work is in support of:

Related:

@zeitlinger
Copy link
Member

I think the content for zipkin doesn't exist anywhere.

It used to be here: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/71b3e3e027f78a2a44007129a4bad32a641d8103/instrumentation/spring/spring-boot-autoconfigure/README.md#features

This should probably be included here directly.
Until then, I'd suggest to create a ticket and remove the link.

@chalin
Copy link
Contributor Author

chalin commented Feb 4, 2025

@zeitlinger - If you have the necessary permissions, would you be willing to edit the file directly in this PR? Otherwise, please add the link(s) to the issues and/or PRs you create as a followup to this PR -- and then I'll close it.

@zeitlinger
Copy link
Member

should I create a documentation issue in this repo?

@chalin
Copy link
Contributor Author

chalin commented Feb 4, 2025

Well, this repo's page content/en/docs/zero-code/java/spring-boot-starter/other-spring-autoconfig.md, referenced in this PR, needs to be updated. So, if you let me know what updates you'd like I can make them. Or, like for the other PR, you can just submit suggestions on this PR. Or you can create an issue in this repo, yes :).

@zeitlinger
Copy link
Member

Well, this repo's page content/en/docs/zero-code/java/spring-boot-starter/other-spring-autoconfig.md, referenced in this PR, needs to be updated. So, if you let me know what updates you'd like I can make them. Or, like for the other PR, you can just submit suggestions on this PR. Or you can create an issue in this repo, yes :).

created #6205

@zeitlinger
Copy link
Member

Or, like for the other PR, you can just submit suggestions on this PR.

done

Copy link
Contributor Author

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zeitlinger, your update LGTM. Will still need others to approve.

@chalin chalin added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit cdd35a2 Feb 4, 2025
20 checks passed
@chalin chalin deleted the chalin-patch-1 branch February 4, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants