Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid links to Prometheus, API pages, and more #6235

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix invalid links to Prometheus, API pages, and more #6235

wants to merge 10 commits into from
+66 −99

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 6, 2025

@chalin chalin requested a review from a team as a code owner February 6, 2025 14:40
@opentelemetrybot opentelemetrybot requested review from a team and djaglowski and removed request for a team February 6, 2025 14:40
chalin
chalin commented Feb 6, 2025
View reviewed changes
layouts/shortcodes/docs/languages/exporters/intro.md
Comment on lines 36 to +37
[Prometheus]:
https://prometheus.io/docs/prometheus/latest/feature_flags/#otlp-receiver
https://prometheus.io/docs/prometheus/2.55/feature_flags/#otlp-receiver
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the link, but the fact that an OTLP-receiver entry no longer exists in the latest version of the docs is probably an indication that this prose needs to be updated (and/or the link to point to something else in the latest docs)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/collector-approvers ☝️

chalin
chalin commented Feb 6, 2025
View reviewed changes
layouts/shortcodes/docs/languages/exporters/prometheus-setup.md
[enable Prometheus' OTLP Receiver](https://prometheus.io/docs/prometheus/latest/feature_flags/#otlp-receiver)
[enable Prometheus' OTLP Receiver](https://prometheus.io/docs/prometheus/2.55/feature_flags/#otlp-receiver)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as https://github.com/open-telemetry/opentelemetry.io/pull/6235/files#r1944849774.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/collector-approvers ☝️

@chalin chalin force-pushed the chalin-im-fix-links-2025-02-06 branch from 3942587 to f966a51 Compare February 6, 2025 14:45
@opentelemetrybot opentelemetrybot requested a review from a team February 6, 2025 14:45
@chalin chalin changed the title Fixes invalid links to Prometheus and Go API pages Fix invalid links to Prometheus and Go API pages Feb 6, 2025
@chalin chalin force-pushed the chalin-im-fix-links-2025-02-06 branch from 7ce1cec to 619c6dc Compare February 6, 2025 16:17
@opentelemetrybot opentelemetrybot requested a review from a team February 6, 2025 16:18
@chalin chalin force-pushed the chalin-im-fix-links-2025-02-06 branch from 842b344 to 7bccc70 Compare February 6, 2025 22:37
chalin
chalin commented Feb 6, 2025
View reviewed changes
content/en/docs/collector/building/authenticator-extension.md
Comment on lines -153 to -154
- [go.opentelemetry.io/collector/config/configauth/GRPCClientAuthenticator](https://pkg.go.dev/go.opentelemetry.io/collector/config/configauth#GRPCClientAuthenticator)
- [go.opentelemetry.io/collector/config/configauth/HTTPClientAuthenticator](https://pkg.go.dev/go.opentelemetry.io/collector/config/configauth#HTTPClientAuthenticator)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These link targets no longer exists (the fragments are invalid), so I've reworked the prose and instead linked to the section headings introduced by https://github.com/open-telemetry/opentelemetry-collector/pull/12309/files (which hasn't been published yet, but the links are still valid -- the link fragments will be validated once 12309 is published.

@chalin chalin mentioned this pull request Feb 6, 2025
Open
9 tasks
@opentelemetrybot opentelemetrybot requested a review from a team February 6, 2025 23:48
chalin
chalin commented Feb 6, 2025
View reviewed changes
content/en/docs/languages/rust/_index.md
- [Ecosystem](https://github.com/open-telemetry/opentelemetry-rust#ecosystem)
- [Overview of crates](https://github.com/open-telemetry/opentelemetry-rust#overview-of-crates)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was made via:

@chalin chalin force-pushed the chalin-im-fix-links-2025-02-06 branch from b46f635 to 5aa6e4e Compare February 6, 2025 23:58
@chalin chalin changed the title Fix invalid links to Prometheus and Go API pages Fix invalid links to Prometheus, API pages, and more Feb 7, 2025
@chalin chalin force-pushed the chalin-im-fix-links-2025-02-06 branch from 5aa6e4e to 870d252 Compare February 7, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski was automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
blog cleanup/refactoring sig:collector sig:rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @svrnm